Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy Flags field from SectorOnChainInfo #11963

Merged
merged 1 commit into from
May 15, 2024

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented May 6, 2024

Fixes: #11962

not sure if v12 is worth updating here, included just in case—is it worth it? whoops, codegen, I've done it for all possible, which is v12 and v13.

@rvagg rvagg requested review from magik6k and ZenGround0 May 6, 2024 02:28
@rvagg rvagg force-pushed the rvagg/sector-on-chain-info-flags branch from 1fdc9d0 to f10f053 Compare May 6, 2024 02:50
@rvagg rvagg marked this pull request as draft May 6, 2024 10:59
@rvagg rvagg force-pushed the rvagg/sector-on-chain-info-flags branch from f10f053 to ddcf05f Compare May 6, 2024 11:05
@rvagg rvagg marked this pull request as ready for review May 6, 2024 11:05
@rvagg
Copy link
Member Author

rvagg commented May 6, 2024

What am I not seeing in this lint job output? https://github.com/filecoin-project/lotus/actions/runs/8968065046/job/24630013957 I've re-run it but it's failing in the same way but I can't see it saying anything about the code.

@rvagg rvagg force-pushed the rvagg/sector-on-chain-info-flags branch from ddcf05f to 08ad152 Compare May 15, 2024 05:09
@rvagg
Copy link
Member Author

rvagg commented May 15, 2024

linter problems fixed @ #11968

@rvagg rvagg enabled auto-merge (rebase) May 15, 2024 05:09
@rvagg rvagg force-pushed the rvagg/sector-on-chain-info-flags branch from 08ad152 to 715311a Compare May 15, 2024 05:35
@rvagg
Copy link
Member Author

rvagg commented May 15, 2024

... and actors v14 gen added

@rvagg rvagg merged commit b38dadb into master May 15, 2024
150 of 188 checks passed
@rvagg rvagg deleted the rvagg/sector-on-chain-info-flags branch May 15, 2024 05:43
@rjan90 rjan90 mentioned this pull request May 16, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flags field is dropped in SectorOnChainInfo conversions
2 participants